refactor: establish Storage folder feature - #334
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
from
August 4, 2026 17:31
2f0d59d to
bd7c33f
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
2 times, most recently
from
August 5, 2026 12:31
1bac0ec to
b42086c
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
from
August 5, 2026 12:34
b42086c to
452ac45
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
2 times, most recently
from
August 5, 2026 13:57
4fff380 to
570559c
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
3 times, most recently
from
August 5, 2026 14:50
c5044d1 to
80eff0d
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
from
August 5, 2026 15:09
80eff0d to
7447d5b
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
from
August 5, 2026 15:45
7447d5b to
3de3011
Compare
jderochervlk
force-pushed
the
codex/option5-storage-folder
branch
from
August 5, 2026 17:40
3de3011 to
1b0a8e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 24 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #333.
Summary
src/storagefolder on the unqualified internalStoragefeatureWebAPI.Storage -> WebAPI.Fetch + StoragefeatureBoundary note
CacheandCacheStoragemove out of the old ServiceWorker/WebWorkers folders because they are available outside workers and their Request/Response signatures explain Storage's Fetch dependency. The remaining worker and service-worker interfaces move together in the next PR.Temporary state
WebWorkersTypescurrently mixes cache and worker support types, so it moves with Storage for this layer; Workers consumes it throughWebAPI.Storage, and final helper cleanup can split it after the graph is completeWebAPI.ServiceWorkerandWebAPI.WebWorkerssource features are transitional until the immediately following Workers PRWindowandDomGlobalstill reference the cache types and are resolved by the later Window integrationReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,File,URL,Fetch,Storagenpm run buildnpm testnpm run format:checkgit diff --check